Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradient clipping #1438

Merged

Conversation

alsrgv
Copy link
Contributor

@alsrgv alsrgv commented Apr 10, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

This PR fixes broken gradient clipping.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Yep :-)

@mergify mergify bot requested review from a team April 10, 2020 00:21
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #1438 into master will not change coverage by %.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1438   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files          66      66           
  Lines        3509    3509           
======================================
  Hits         3213    3213           
  Misses        296     296           

@williamFalcon williamFalcon merged commit 8dd9b80 into Lightning-AI:master Apr 10, 2020
@alsrgv alsrgv deleted the alsrgv/fix_grad_clipping branch April 10, 2020 01:12
@alsrgv
Copy link
Contributor Author

alsrgv commented Apr 10, 2020

Thanks for a quick merge!

@Borda Borda added the bug Something isn't working label Apr 10, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
* Fix gradient clipping

* Relax accuracy constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants